Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove LogStabilityLevel, not used #9347

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 23, 2024

Remove LogStabilityLevel as it is not used anywhere and is an internal struct.

@atoulme atoulme requested review from a team and dmitryax January 23, 2024 07:37
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d78b748) 90.38% compared to head (c57ce67) 90.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9347      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files         341      340       -1     
  Lines       17986    17980       -6     
==========================================
- Hits        16256    16247       -9     
- Misses       1407     1409       +2     
- Partials      323      324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we log this instead?

@dmitryax
Copy link
Member

It's part of the component builder now

func (b *Builder) CreateTraces(ctx context.Context, set CreateSettings) (Traces, error) {

@dmitryax dmitryax merged commit 08955ae into open-telemetry:main Jan 23, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 23, 2024
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this pull request Jan 23, 2024
)

Remove `LogStabilityLevel` as it is not used anywhere and is an internal
struct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants