Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Clarify timeline strictness in stabilization issues. #9378

Merged

Conversation

TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth requested review from a team and codeboten January 24, 2024 16:59
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9047c0e) 90.16% compared to head (9883c88) 90.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9378   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files         345      345           
  Lines       18025    18027    +2     
=======================================
+ Hits        16253    16255    +2     
  Misses       1442     1442           
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -6,7 +6,7 @@ labels: 'stabilization'
assignees: ''
---

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:
Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the thing that blocks us then is not the issue but doing the announcements on Slack/the Collector SIG meetings. Is it worth removing these and making a general announcement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth removing these and making a general announcement?

Does these refer to opening these issues? We could probably get by with only the Milestones, but personally I like these issues as a helpful checklist and place for centralized stabilization discussion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mx-psi is saying that the longest wait is the announcements, because otherwise you'd be able to open the issue, check the checklist and see that for the last 2 releases, everything was done, and quickly move to stable. But you wouldn't really make announcements before opening the issue. So we could make a big announcement of our intentions in general, and dispense of announcing each module one by one.

I think after this wave, we could make a general announcement and remove the requirement, if we feel good about our progress.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, exactly what Antoine said :) Thanks for clarifying my confusing message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yes that makes sense to me.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as a step towards a bit less waiting.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a change is in the right direction, we can discuss the announcements thing separately

@mx-psi mx-psi merged commit 7119115 into open-telemetry:main Jan 31, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 31, 2024
@TylerHelmuth TylerHelmuth deleted the update-stabilization-template-text branch January 31, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants