-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Clarify timeline strictness in stabilization issues. #9378
[chore] Clarify timeline strictness in stabilization issues. #9378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9378 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 345 345
Lines 18025 18027 +2
=======================================
+ Hits 16253 16255 +2
Misses 1442 1442
Partials 330 330 ☔ View full report in Codecov by Sentry. |
@@ -6,7 +6,7 @@ labels: 'stabilization' | |||
assignees: '' | |||
--- | |||
|
|||
Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases: | |||
Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the thing that blocks us then is not the issue but doing the announcements on Slack/the Collector SIG meetings. Is it worth removing these and making a general announcement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth removing these and making a general announcement?
Does these
refer to opening these issues? We could probably get by with only the Milestones, but personally I like these issues as a helpful checklist and place for centralized stabilization discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mx-psi is saying that the longest wait is the announcements, because otherwise you'd be able to open the issue, check the checklist and see that for the last 2 releases, everything was done, and quickly move to stable. But you wouldn't really make announcements before opening the issue. So we could make a big announcement of our intentions in general, and dispense of announcing each module one by one.
I think after this wave, we could make a general announcement and remove the requirement, if we feel good about our progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, exactly what Antoine said :) Thanks for clarifying my confusing message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok yes that makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, as a step towards a bit less waiting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a change is in the right direction, we can discuss the announcements thing separately
No description provided.