Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Deprecate QueueSettings, use QueueConfig instead #9393

Closed

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 25, 2024

Description:
Deprecate QueueSettings, use QueueConfig instead

Link to tracking Issue:
#6767

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b3b181) 90.23% compared to head (513e1aa) 90.19%.
Report is 2 commits behind head on main.

Files Patch % Lines
exporter/exporterhelper/common.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9393      +/-   ##
==========================================
- Coverage   90.23%   90.19%   -0.04%     
==========================================
  Files         345      345              
  Lines       18017    18028      +11     
==========================================
+ Hits        16257    16260       +3     
- Misses       1431     1440       +9     
+ Partials      329      328       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

Let's hold off on this. I wanted to incorporate it with migration to the new helper to avoid several breaking changes #8853

@atoulme
Copy link
Contributor Author

atoulme commented Jan 26, 2024

Going to close for now, and we can always reopen if plans change.

@atoulme atoulme closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants