Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] move implementation checks to test files #9433

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 30, 2024

Description:
move implementation checks to test files
Link to tracking Issue:
#9431

@atoulme atoulme requested review from a team and dmitryax January 30, 2024 17:21
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07a00ff) 90.18% compared to head (083a333) 90.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9433      +/-   ##
==========================================
- Coverage   90.18%   90.16%   -0.03%     
==========================================
  Files         345      345              
  Lines       18019    18019              
==========================================
- Hits        16251    16246       -5     
- Misses       1438     1442       +4     
- Partials      330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 90a7c7a into open-telemetry:main Jan 30, 2024
33 of 35 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants