-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configcompression] make IsCompressed
a member function
#9435
Merged
dmitryax
merged 7 commits into
open-telemetry:main
from
TylerHelmuth:configcompression-make-member-func
Feb 1, 2024
Merged
[configcompression] make IsCompressed
a member function
#9435
dmitryax
merged 7 commits into
open-telemetry:main
from
TylerHelmuth:configcompression-make-member-func
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9435 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 344 344
Lines 17932 17957 +25
==========================================
+ Hits 16182 16207 +25
Misses 1421 1421
Partials 329 329 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 30, 2024
bogdandrutu
reviewed
Jan 30, 2024
Co-authored-by: Bogdan Drutu <[email protected]>
mx-psi
approved these changes
Feb 1, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
dmitryax
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates
IsCompressed
to be a member function.Link to tracking Issue:
Closes #9434
Testing:
Documentation:
Please delete paragraphs that you did not use before submitting.