Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix unused params #9578

Merged

Conversation

codeboten
Copy link
Contributor

Related to #9577

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and djaglowski February 13, 2024 18:20
@@ -953,7 +953,7 @@ func TestDefaultUnaryInterceptorAuthFailure(t *testing.T) {
authCalled = true
return context.Background(), expectedErr
}
handler := func(ctx context.Context, req any) (any, error) {
handler := func(_ context.Context, _ any) (any, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplify even more, same everywhere where you have all params with _:

Suggested change
handler := func(_ context.Context, _ any) (any, error) {
handler := func(context.Context, any) (any, error) {

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8991654) 90.55% compared to head (3947c19) 90.57%.
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/builder/internal/command.go 0.00% 0 Missing and 1 partial ⚠️
cmd/builder/internal/version.go 0.00% 0 Missing and 1 partial ⚠️
config/configtls/configtls.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9578      +/-   ##
==========================================
+ Coverage   90.55%   90.57%   +0.01%     
==========================================
  Files         347      347              
  Lines       18247    18247              
==========================================
+ Hits        16524    16527       +3     
+ Misses       1392     1390       -2     
+ Partials      331      330       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 4688461 into open-telemetry:main Feb 13, 2024
45 of 46 checks passed
@codeboten codeboten deleted the codeboten/fix-unused-params branch February 13, 2024 19:04
@github-actions github-actions bot added this to the next release milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants