Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update attribute_keys to include type #111

Merged

Conversation

codeboten
Copy link
Contributor

This updates the stream's attribute_keys configuration to an include/exclude style object that currently only supports included. This is in hope to support excluded in the future once the specification allows it.

Fixes #98

This updates the stream's `attribute_keys` configuration to an include/exclude style object that
currently only supports `included`. This is in hope to support `excluded` in the future once the
specification allows it.

Fixes open-telemetry#98

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team August 19, 2024 16:30
CHANGELOG.md Outdated Show resolved Hide resolved
examples/kitchen-sink.yaml Outdated Show resolved Hide resolved
examples/kitchen-sink.yaml Outdated Show resolved Hide resolved
@codeboten codeboten merged commit 26fbfbb into open-telemetry:main Aug 20, 2024
2 checks passed
@codeboten codeboten deleted the codeboten/include-attribute-keys branch August 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should attribute_keys in stream configuration support include/exclude syntax?
3 participants