Add Default Histogram Aggregation in prometheus schema #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishekkr3003
force-pushed
the
prometheus-exponential-bucket-histogram-config
branch
from
5e5796f
to
6604a34
Compare
jack-berg
reviewed
Jul 2, 2024
There was a problem hiding this comment.
We have a policy to only add schema surface area for configuration options which are defined in the spec. I'm supportive of this change and opened open-telemetry/opentelemetry-specification#4124 to add the corresponding option in the spec, which would unblock this.
Co-authored-by: jack-berg <[email protected]>
Thanks a lot @jack-berg! |
|
This is superseded by #107, which solves the problem more generally and for all metric exporters. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for providing default_histogram_aggregation via a config file for Prometheus Metric Exporter.
Support for configuring Default Histogram Aggregation for Prometheus exporter is added in this PR: open-telemetry/opentelemetry-java#6541.