Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HTTPTextFormat to TextMapPropagator #536

Closed
lalitb opened this issue Jan 27, 2021 · 3 comments · Fixed by #586 · May be fixed by TomRoSystems/opentelemetry-cpp#3
Closed

Rename HTTPTextFormat to TextMapPropagator #536

lalitb opened this issue Jan 27, 2021 · 3 comments · Fixed by #586 · May be fixed by TomRoSystems/opentelemetry-cpp#3
Assignees
@TomRoSystems
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers priority:p1 Issues that are blocking release:required-for-ga To be resolved before GA release

Comments

@lalitb
Copy link
Member

lalitb commented Jan 27, 2021 •
edited
Loading

As per the specs:
https://github.com/open-telemetry/opentelemetry-specification/blob/b17f8c993af285cfb0b9cfeb872c15911c720ad2/specification/context/api-propagators.md#textmap-propagator

The relevant specs PR : open-telemetry/opentelemetry-specification#793
@lalitb lalitb added good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers priority:p2 Issues that are not blocking release:required-for-ga To be resolved before GA release labels Jan 27, 2021
@lalitb lalitb added priority:p1 Issues that are blocking and removed priority:p2 Issues that are not blocking labels Jan 27, 2021
@lalitb lalitb changed the title Implement TextMapPropagator Rename TextMapPropagator to TextMapPropagator Feb 2, 2021
@lalitb lalitb changed the title Rename TextMapPropagator to TextMapPropagator Rename HTTPTextFormat to TextMapPropagator Feb 2, 2021
@lalitb
Copy link
Member Author

lalitb commented Feb 10, 2021

@TomRoSystems - Can you please assign it to yourself. Not sure why I can't find your alias for Assignees.

@ThomsonTan ThomsonTan assigned ThomsonTan and unassigned ThomsonTan Feb 10, 2021
@ThomsonTan
Copy link
Contributor

Probably need to join the OpenTelemetry community to be part of assignee? See below link for examples. I am assigning this issue to myself just for keeping it for @TomRoSystems. Feel free to take it once you join the community.

https://github.com/open-telemetry/community/issues

@TomRoSystems TomRoSystems mentioned this issue Feb 11, 2021
Closed
6 tasks
@TomRoSystems
Copy link
Member

Probably need to join the OpenTelemetry community to be part of assignee? See below link for examples. I am assigning this issue to myself just for keeping it for @TomRoSystems. Feel free to take it once you join the community.

https://github.com/open-telemetry/community/issues

Thanks. I've already become a member. Please re-assign to me.

TomRoSystems added a commit to TomRoSystems/opentelemetry-cpp that referenced this issue Feb 22, 2021
@TomRoSystems
Rename HTTPTextFormat to TextMapPropagator
1ac8e9f 
Fixes open-telemetry#536
As per spec open-telemetry/opentelemetry-specification#793
This was referenced Feb 22, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomRoSystems TomRoSystems

Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers priority:p1 Issues that are blocking release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
3 participants
@ThomsonTan @lalitb @TomRoSystems