[Metrics SDK] Change boundry type to double for Explicit Bucket Histogram Aggregation, and change default bucket range
#1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
double in Explicit Bucket Histogram Aggregationdouble for Explicit Bucket Histogram Aggregation
lalitb
changed the title
double for Explicit Bucket Histogram Aggregationdouble for Explicit Bucket Histogram Aggregation
reyang
reviewed
Sep 21, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
- Coverage 85.09% 85.08% -0.00%
==========================================
Files 159 159
Lines 5001 4991 -10
==========================================
- Hits 4255 4246 -9
+ Misses 746 745 -1
|
lalitb
changed the title
double for Explicit Bucket Histogram Aggregationdouble for Explicit Bucket Histogram Aggregation
lalitb
changed the title
double for Explicit Bucket Histogram Aggregationdouble for Explicit Bucket Histogram Aggregation, and change default bucket range
ThomsonTan
reviewed
Sep 30, 2022
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
…togram Aggregation, and change default bucket range (open-telemetry#1626) * fix bucket boundaries type for histogram aggregation * update bucket range, and fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1628, #1629
Irrespective of the aggregation data type (
longordouble) for values stored in buckets, the boundaries range should be always of typedouble.As mentioned in the specs - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation
This PR fixes it.
Also, change the default buckets as per specs changes - open-telemetry/opentelemetry-specification#2770 from
0, 5, 10, 25, 50, 75, 100, 250, 500, 1000to0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000