-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMANTIC CONVENTIONS] Upgrade to 1.21.0 #2248
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 87.30% 87.32% +0.03%
==========================================
Files 169 169
Lines 4897 4897
==========================================
+ Hits 4275 4276 +1
+ Misses 622 621 -1 |
Rename http.client_ip -> client.address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for the upgrade. Not related to this PR, but the trace and resource header files are quite big now. Also, someone interested in only DB-specific instrumentation will have HTTP-related static variables getting created and never used.
You know this part better, but is it feasible to generate domain-specific header files, say trace/semantic_convention_db.h
, trace/semantic_convention_http.h
etc? We can still have the existing trace/semantic_convention.h
which includes all these domain-specific header files. If feasible, we can have an issue created for someone to pick.
This can be investigated. The risk I see is that the build scripts and the header file layout produced will be more coupled to the internal code organization in the semantic-convention/model directory:
I would rather wait for a couple of semantic-conventions releases first, to make sure the code layout itself is stable, before we can consider this. |
Fixes #2138
Changes
Upgrade:
Adjust code per the following semantic convention changes:
net.peer.*
/net.host.*
withclient.*
/server.*
(andsource.*
/destination.*
) opentelemetry-specification#3402url.*
attributes, and improve use of namespacing underhttp.*
opentelemetry-specification#3355For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes