Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Upgrade bazel abseil from 20220623.1 to 20230802.2 #2650

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Apr 29, 2024

Fixes # (issue)

Context

Recently, the CI in github upgraded the MacOS runners from version 2.315.0 to 2.316.0.

Before: https://github.com/actions/runner-images/blob/macOS-12/20240412.2/images/macos/macos-12-Readme.md

After: https://github.com/actions/runner-images/blob/macos-14-arm64/20240422.3/images/macos/macos-14-arm64-Readme.md

This broke the build, due to errors related to C++ traits in abseil headers.

Because the MacOS build is flagged as required, this issue actually is critical, because it prevents to merge any PR.

Changes

Please provide a brief description of the changes here.

  • Upgrade abseil in the bazel build to 20230802.2
  • This restores CI in a working state.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff changed the title Upgrade bazel abseil [BUILD] Upgrade bazel abseil from 20220623.1 to 20230802.2 Apr 29, 2024
@marcalff marcalff marked this pull request as ready for review April 29, 2024 16:59
@marcalff marcalff requested a review from a team April 29, 2024 16:59
@marcalff marcalff added issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review labels Apr 29, 2024
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb
Copy link
Member

lalitb commented Apr 29, 2024

Thanks, so upgrading to anything greater than abseil-cpp-20230802.2 breaks the build ?

@marcalff
Copy link
Member Author

Thanks, so upgrading to anything greater than abseil-cpp-20230802.2 breaks the build ?

Yes, but in a different way.

It breaks because abseil type traits conflicts with std, this probably is an issue with the C++ standard used and WITH_STL.

To resolve separately with #2619.

@marcalff marcalff merged commit 0ca7d70 into open-telemetry:main Apr 29, 2024
48 checks passed
@marcalff marcalff deleted the fix_bazel_macos branch June 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants