Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Restore Bazel flag removed from public API #2702

Merged
merged 4 commits into from
Jun 15, 2024
Merged

[BUILD] Restore Bazel flag removed from public API #2702

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68e6b5d
fix(ci): restore Bazel flag removed from public API
dbolduc Jun 14, 2024
173800d
Merge branch 'main' into restore-public-api-flag-bazel
marcalff Jun 15, 2024
4535b1d
Merge branch 'main' into restore-public-api-flag-bazel
marcalff Jun 15, 2024
cbceed1
Update api/BUILD
marcalff Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion api/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright The OpenTelemetry Authors
# SPDX-License-Identifier: Apache-2.0

load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag", "string_flag")

package(default_visibility = ["//visibility:public"])

Expand Down Expand Up @@ -55,3 +55,9 @@ config_setting(
constraint_values = ["@bazel_tools//tools/cpp:msvc"],
flag_values = {":with_cxx_stdlib": "best"},
)

bool_flag(
name = "with_abseil",
build_setting_default = False,
deprecation = "The value of this flag is ignored. Bazel builds always depend on Abseil for its pre-adopted `std::` types. You should remove this flag from your build command.",
)