Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and enhance tracing support for product catalog service (Go) #50

Closed
2 of 10 tasks
cartersocha opened this issue May 30, 2022 · 1 comment · Fixed by #143
Closed
2 of 10 tasks

Review and enhance tracing support for product catalog service (Go) #50

cartersocha opened this issue May 30, 2022 · 1 comment · Fixed by #143
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022 •
edited by puckpuck
Loading

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)
  • Update the centralized tracing doc
    Referencing: Ensure sufficient breadth in trace features across services #42

Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/productcatalogservice/README.md
@cartersocha cartersocha added enhancement New feature or request help wanted Extra attention is needed required-for-release labels May 30, 2022
@fatsheep9146 fatsheep9146 mentioned this issue Jun 16, 2022
Merged
2 tasks
@cartersocha cartersocha reopened this Jun 20, 2022
@fatsheep9146 fatsheep9146 mentioned this issue Jun 21, 2022
Closed
6 tasks
@cartersocha cartersocha added good first issue Good for newcomers and removed required-for-release labels Jul 14, 2022
@cartersocha cartersocha mentioned this issue Jul 26, 2022
Closed
@cartersocha
Copy link
Contributor Author

Tracing is code complete

dashpole pushed a commit to dashpole/opentelemetry-demo that referenced this issue May 16, 2024
@damemi
Add Cloud Build deploy config (open-telemetry#50)
25a4701 
* Add Cloud Build deploy config

* Add cloudbuild-deploy.yaml to ignore licenses check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
OpenTelemetry Community Demo - Completeness
Status: Done
Milestone
No milestone
1 participant
@cartersocha