Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[currency] - fix rpc.service attribute #1333

Merged
merged 6 commits into from
Jan 19, 2024
Merged

[currency] - fix rpc.service attribute #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3db31a5
add package name for rpc.service attribute
puckpuck Jan 16, 2024
1ea69f0
Merge branch 'main' into currency.fix-rpc.service
puckpuck Jan 16, 2024
a346fe0
add package name for rpc.service attribute
puckpuck Jan 16, 2024
4d1b086
add package name for rpc.service attribute
puckpuck Jan 16, 2024
9df2ce1
add package name for rpc.service attribute
puckpuck Jan 16, 2024
a32ff16
Merge branch 'main' into currency.fix-rpc.service
puckpuck Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ release.

* [grafana] update grafana to 10.2.3
([#1332](https://github.com/open-telemetry/opentelemetry-demo/pull/1332))
* [currencyservice] - add package name prefix to `rpc.service` attribute
([#1333](https://github.com/open-telemetry/opentelemetry-demo/pull/1333))

## 1.7.2

Expand Down
4 changes: 2 additions & 2 deletions src/currencyservice/src/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class CurrencyService final : public oteldemo::CurrencyService::Service
auto span =
get_tracer("currencyservice")->StartSpan(span_name,
{{SemanticConventions::kRpcSystem, "grpc"},
{SemanticConventions::kRpcService, "CurrencyService"},
{SemanticConventions::kRpcService, "oteldemo.CurrencyService"},
{SemanticConventions::kRpcMethod, "GetSupportedCurrencies"},
{SemanticConventions::kRpcGrpcStatusCode, 0}},
options);
Expand Down Expand Up @@ -173,7 +173,7 @@ class CurrencyService final : public oteldemo::CurrencyService::Service
auto span =
get_tracer("currencyservice")->StartSpan(span_name,
{{SemanticConventions::kRpcSystem, "grpc"},
{SemanticConventions::kRpcService, "CurrencyService"},
{SemanticConventions::kRpcService, "oteldemo.CurrencyService"},
{SemanticConventions::kRpcMethod, "Convert"},
{SemanticConventions::kRpcGrpcStatusCode, 0}},
options);
Expand Down
Loading