Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[productcatalogservice] adds otel log support #1479

Conversation

Kimbohlovette
Copy link

This branch implements otel loging support for the product catalog service

@Kimbohlovette Kimbohlovette requested a review from a team March 24, 2024 01:37
@Kimbohlovette
Copy link
Author

@puckpuck @jpkrohling please look at this PR.

@Kimbohlovette Kimbohlovette changed the title Add otel log support to the product catalog service [productcatalogservice] adds otel log support Mar 24, 2024
@puckpuck
Copy link
Contributor

@Kimbohlovette This also includes the changes from your checkoutservice PR. The changes to the productcatalog files look fine, but we would want the changes to be contained to a single service.

@Kimbohlovette
Copy link
Author

@Kimbohlovette This also includes the changes from your checkoutservice PR. The changes to the productcatalog files look fine, but we would want the changes to be contained to a single service.

Okay @puckpuck, I will reset the commit and do it as requested

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on #1477

Copy link

github-actions bot commented Apr 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@github-actions github-actions bot removed the Stale label Apr 3, 2024
@julianocosta89 julianocosta89 marked this pull request as draft April 3, 2024 11:10
@julianocosta89
Copy link
Member

I spoke with @Kimbohlovette today and mentioned that this is not supported yet as OTel logs in Go are still in development.
He will reach out to the OTel Go team to check if he can help out on bringing this to Stable.

Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants