-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[productcatalogservice] adds otel log support #1479
[productcatalogservice] adds otel log support #1479
Conversation
@puckpuck @jpkrohling please look at this PR. |
@Kimbohlovette This also includes the changes from your checkoutservice PR. The changes to the productcatalog files look fine, but we would want the changes to be contained to a single service. |
Okay @puckpuck, I will reset the commit and do it as requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on #1477
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I spoke with @Kimbohlovette today and mentioned that this is not supported yet as OTel logs in Go are still in development. Closing this PR for now. |
This branch implements otel loging support for the product catalog service