-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move dependencies control to .env file #1715
[chore] Move dependencies control to .env file #1715
Conversation
I'm open to suggestions, because I strongly believe we should have a centralised place to manage the versions. As of today we have to update 3 files every time the java agent updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.env FTW! I like the idea of controlling as much as possible the versions from a single file
Could this be changed to use |
Unfortunately I'm not a Github actions expert. We have this in the GH marketplace: https://github.com/marketplace?query=docker+compose @puckpuck any ideas/suggestions? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I'm gonna close this one as I can't fix the GH actions right now. |
Changes
A couple of dependencies had to be updated in multiple places, this PR moves all of them to
.env
file.Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.