Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move dependencies control to .env file #1715

Closed

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Sep 6, 2024

Changes

A couple of dependencies had to be updated in multiple places, this PR moves all of them to .env file.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team September 6, 2024 11:03
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Sep 6, 2024
@julianocosta89
Copy link
Member Author

build_images is not using docker compose 😞

I'm open to suggestions, because I strongly believe we should have a centralised place to manage the versions.

As of today we have to update 3 files every time the java agent updates.
2 places every time there is an update to opensearch or tracetest.

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env FTW! I like the idea of controlling as much as possible the versions from a single file

.env Show resolved Hide resolved
@rogercoll
Copy link
Contributor

build_images is not using docker compose 😞

Could this be changed to use docker compose build? 🤔 I agree that relying on a single dependencies file would ease the maintenance

@julianocosta89
Copy link
Member Author

Unfortunately I'm not a Github actions expert.
I've googled a bit around and I'm still not sure.

We have this in the GH marketplace: https://github.com/marketplace?query=docker+compose
But only 5 of those are verified and none of those 5 do what we need here.

@puckpuck any ideas/suggestions?

@julianocosta89 julianocosta89 requested a review from a team as a code owner September 23, 2024 09:53
Copy link

github-actions bot commented Oct 1, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 1, 2024
@github-actions github-actions bot removed the Stale label Oct 8, 2024
@julianocosta89
Copy link
Member Author

I'm gonna close this one as I can't fix the GH actions right now.

@julianocosta89 julianocosta89 deleted the chore-organize-deps branch November 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants