Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add depends on to otelcol to wait on healthy opensearch #1724

Merged

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Sep 23, 2024

Changes

Fix: #1723

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • [ ] Appropriate documentation updates in the docs
  • [ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team as a code owner September 23, 2024 07:42
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Sep 23, 2024
@julianocosta89 julianocosta89 changed the title Add depends on to otelcol [chore] Add depends on to otelcol to wait on healthy opensearch Sep 23, 2024
@julianocosta89
Copy link
Member Author

@rogercoll would you be able to take a look at this one?
We don't have many active approvers ATM 😓

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a small nit (I am okay with green status only too :) )

docker-compose.minimal.yml Outdated Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit 34d95c9 into open-telemetry:main Oct 7, 2024
28 checks passed
@julianocosta89 julianocosta89 deleted the otelcol-depends-on branch October 7, 2024 11:47
benakansara pushed a commit to benakansara/opentelemetry-demo that referenced this pull request Oct 15, 2024
…-telemetry#1724)

* Add depends on to otelcol

* changelog

* Update docker-compose.minimal.yml

Co-authored-by: Roger Coll <[email protected]>

---------

Co-authored-by: Roger Coll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otel-col error messages while openseach is not reacheable
2 participants