-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
39 Moving the Front end application from Go to Next.js #236
Conversation
Make sure to go ahead & sign the cla @xoscar |
Thanks for your contribution, @xoscar! |
Could we get the checks passing on this to move it forward? |
I believe that we can also get rid of the social network icons, we are not using them within the FE. |
I didn't mark the PR as need work because I'm will be OoO for some time, but went through all files and added my review! This was a really massive one 😅 |
Ah, btw... |
@wph95 , @cedricziel , @mic-max , @open-telemetry/demo-approvers - ready for final reviews |
Hey @mic-max thanks for reviewing the PR 😁 I just updated it based on your changes, let me know if that's good enough to merge the changes. @cartersocha I think we need to press the button one last time 😄 |
I don't know how to effectively review any PR that has more than a hundred files. Maybe it should be changed to a series of smaller PRs? |
The idea of one big PR was to not have intermediate commits where the frontend might be broken, this PR adds all of the features the GO version used to have plus the new redesigns. The next ones should be fairly small as we will only focus on one section like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing it 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @xoscar
Thanks @xoscar! Huge contribution 🌟 |
Thank you @xoscar for this!!! 💯 |
Fixes #39.
Changes
In this PR we are introducing the new front-end version. In this version, we are focusing on having a browser-side client written in Typescript.
The frontend was built based on the proposal presented during the last SIG call (July 25th 2022) and can be found here: https://docs.google.com/presentation/d/1klWGRAcFYJLBrXtMMRGHJvwQaMt1JPWnO7qQzFdJti4/edit?usp=sharing
Next Steps:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesVideo demo
https://www.loom.com/share/c7b1c559346e4a4c8df4e670ef14b558
Screenshots