Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent #237

Conversation

dineshg13
Copy link
Member

Fixes a part of #73

Changes

Please provide a brief description of the changes here.

  1. Update javaagent jar to the latest version
  2. Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT as required by java agent . The variables are listed here https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/README.md#otlp-exporter-both-span-and-metric-exporters

Post this change , when we do docker compose up , we should see jvm metrics in prometheus

Screen Shot 2022-07-26 at 6 39 06 PM

@dineshg13 dineshg13 requested a review from a team July 26, 2022 22:40
@puckpuck
Copy link
Contributor

Should we be using the OTEL_EXPORTER_OTLP_ENDPOINT environment variable only? We only have a single collector endpoint for all OTLP data, and shouldn't need to use the TRACES and METRICS specific flavors.

@julianocosta89
Copy link
Member

@puckpuck, I'd argue that if we keep _TRACES and _METRICS we are "showcasing" how to use env vars to configure those 2 signals, even though they are pointing to the same collector.

Personally I'd accept this PR.

@austinlparker
Copy link
Member

I suppose explicit is better than implicit, although I wonder if there are other implications of using the separate env vars for configuration?

@dineshg13
Copy link
Member Author

i agree with @julianocosta89 & @austinlparker . i like variables being explicit in demo application.

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed at the SIG meeting and we'd like to use explicit variables for each signal.

.env Outdated Show resolved Hide resolved
@cartersocha
Copy link
Contributor

@dineshg13 could you please update the changelog too

@cartersocha cartersocha merged commit fb5d741 into open-telemetry:main Aug 2, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…elemetry#237)

* Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent

* Remove unneeded line + add Changelog

Co-authored-by: Austin Parker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants