-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent #237
Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent #237
Conversation
Should we be using the |
@puckpuck, I'd argue that if we keep Personally I'd accept this PR. |
I suppose explicit is better than implicit, although I wonder if there are other implications of using the separate env vars for configuration? |
i agree with @julianocosta89 & @austinlparker . i like variables being explicit in demo application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed at the SIG meeting and we'd like to use explicit variables for each signal.
@dineshg13 could you please update the changelog too |
…elemetry#237) * Set OTEL_EXPORTER_OTLP_METRICS_ENDPOINT needed for Java agent * Remove unneeded line + add Changelog Co-authored-by: Austin Parker <[email protected]>
Fixes a part of #73
Changes
Please provide a brief description of the changes here.
Post this change , when we do
docker compose up
, we should see jvm metrics in prometheus