Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support override java agent jar. #244

Merged
merged 3 commits into from
Aug 3, 2022
Merged

support override java agent jar. #244

merged 3 commits into from
Aug 3, 2022

Conversation

JaredTan95
Copy link
Member

Fixes #243.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@JaredTan95 JaredTan95 requested a review from a team August 1, 2022 04:51
@puckpuck
Copy link
Contributor

puckpuck commented Aug 1, 2022

This can be done as a separate PR. We should also update how the Agent's jar file is sourced. Right now the binary is part of this repo, but really we should be pulling it from the Java instrumentation releases instead. ie: https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v1.16.0/opentelemetry-javaagent.jar

@JaredTan95
Copy link
Member Author

but really we should be pulling it from the Java instrumentation releases instead

okay, I will update it with a separate PR soon.

@cartersocha cartersocha merged commit 7ce42fd into open-telemetry:main Aug 3, 2022
@JaredTan95 JaredTan95 deleted the enhance_inject_way branch August 3, 2022 03:58
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support inject agent/sidecar through opentelemetry-operator annoatatons.
3 participants