Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto instrumentation to frontend service #291

Closed
wants to merge 1 commit into from

Conversation

cedricziel
Copy link
Contributor

Changes

This traces the nextJS backend part of the frontend service.

Since I didnt want to swap out large amounts of code in an unknown framework,
I just applied the auto-instrumentation from the operator by requiring and starting
a customized version of the SDK.

Customizations based on https://ross-hagan.com/blog/instrument-nextjs-opentelemetry

image

@cedricziel cedricziel marked this pull request as ready for review August 11, 2022 10:23
@cedricziel cedricziel requested a review from a team August 11, 2022 10:23
@puckpuck
Copy link
Contributor

I like where this is going, but using the operator's autoinstrumentation image to pull in the OpenTelemetry dependencies will limit the dev experience. Can we update the frontend's package.json file to pull in the dependencies within the dev environment instead?

@xoscar
Copy link
Contributor

xoscar commented Aug 11, 2022

Hey @cedricziel I also worked on some instrumentation for the front end (serverside/client side) you can find it here #293

@puckpuck
Copy link
Contributor

I think we should close this and look to finish #293

@cedricziel
Copy link
Contributor Author

Sweet! Closing here..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants