Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 [Frontend] 284 adding cypress e2e tests #298

Merged
merged 8 commits into from
Aug 16, 2022
Merged

🧪 [Frontend] 284 adding cypress e2e tests #298

merged 8 commits into from
Aug 16, 2022

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Aug 12, 2022 •
edited
Loading

Fixes #284.

Changes

  • Adds E2E integration test for the frontend using Cypress.
  • Fixes the backend services integration tests by dockerizing them.

https://www.loom.com/share/e6e2cbba1ca84bfb8670805b53090d77

Running e2e tests:
docker compose run frontendtests

Running backend integration tests:
docker compose run integrationTests

@xoscar xoscar marked this pull request as ready for review August 12, 2022 21:17
@xoscar xoscar requested a review from a team August 12, 2022 21:17
xoscar
xoscar commented Aug 12, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@xoscar xoscar changed the title 284 adding cypress e2e tests 🧪 [Frontend] 284 adding cypress e2e tests Aug 12, 2022
mic-max
mic-max suggested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some minor questions / feedback I left

docker-compose.yml Outdated Show resolved Hide resolved
src/frontend/cypress.config.ts Show resolved Hide resolved
src/frontend/cypress.config.ts Outdated Show resolved Hide resolved
src/frontend/cypress/e2e/Checkout.cy.ts Outdated Show resolved Hide resolved
src/frontend/cypress/support/commands.ts Outdated Show resolved Hide resolved
test/Dockerfile Show resolved Hide resolved
test/Dockerfile Outdated Show resolved Hide resolved
test/Dockerfile Outdated Show resolved Hide resolved
test/test.js Outdated Show resolved Hide resolved
test/test.js Show resolved Hide resolved
jorgeepc
jorgeepc reviewed Aug 15, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@xoscar
Copy link
Contributor Author

xoscar commented Aug 15, 2022

Hey @mic-max thanks for the review! I just updated the PR, let me know what you think 😄

@cartersocha
Copy link
Contributor

Lgtm. @xoscar could you add a change log entry & I'll merge

@xoscar
Copy link
Contributor Author

xoscar commented Aug 16, 2022

@cartersocha done 😄

@cartersocha cartersocha merged commit 4b316bd into open-telemetry:main Aug 16, 2022
@mviitane mviitane mentioned this pull request Aug 16, 2022
Closed
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@xoscar
🧪 [Frontend] 284 adding cypress e2e tests (open-telemetry#298)
1de1a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc left review comments

@mic-max mic-max mic-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Add Tests to Frontend
4 participants
@xoscar @cartersocha @jorgeepc @mic-max