-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP quote service #345
Add PHP quote service #345
Conversation
@bobstrecansky could you take a look? |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good to me. it's based on one of our demos and there are a couple of things unused that could be removed.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for tackling the beast that is PHP ;p
Update the issue this resolves since we decided PHP to be a quote service instead of an admin portal 👍
@brettmc would you mind doing a final review on this? |
Co-authored-by: Michael Maxwell <[email protected]>
Co-authored-by: Brett McBride <[email protected]>
Co-authored-by: Brett McBride <[email protected]>
There is no load to the service yet, but we can test in this way ATM: docker compose up quoteservice --build
You can change the numberOfItems to get different quotes. |
@brettmc everything should be good to go 🤩 |
@julianocosta89 great work on this. Are we ready to merge or are there outstanding items? I see the docs are mostly updated and we can clean up the rest post merge |
@cartersocha all good to go! |
Towards #57.
Changes
Adding PHP service - QuoteService, which will receive requests from ShippingService, calculate the shipping costs and return the quote to Shipping.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes