[frontend] [ops golf?] Pass collector URL to frontend via reverse proxy. #508
Conversation
|
@puckpuck had an excellent idea to use envoy rather than nginx. there is one small catch here, that we have to build an envoy container in order to get Someone more enterprising than I can enable tracing/metrics off this post v1. |
|
The frontend is broken on my machine? Is port 8080 still the right connection or do I need to navigate to the reverse proxy? |
|
If we update the docker file to port 80 we should be good |
|
and changelog + architecture |
what part of the dockerfile? the compose file or the frontend? |
|
We need to update the readmes to indicate we run on port 80 now |
|
Updated the docker readme with the current state |
|
Not for this PR, but it would be nice if there is a way to force mermaid to not draw a box in the top right corner that gets covered by the github icons |
This reverts commit 63c7bcf.
…ectorToFE # Conflicts: # docs/kubernetes_deployment.md
…xy. (open-telemetry#508) * support setting collector URL for browser * rename to frontend-proxy * refactor to use envoy rather than nginx * cleanup * fix composefile * delete unneeded nginx conf template * cleanup naming * set cors to * * also front ffs with envoy * update docs, changelog, etc * update one more port mapping in docs * update for envoy url * update for envoy url * Revert "update for envoy url" This reverts commit 63c7bcf. * fixup Co-authored-by: Pierre Tessier <[email protected]>
This fixes the current problem of the collector URL not being passed into the frontend, as Next.JS will not pass env vars into the client except ones known at build time.
It accomplishes this by way of establishing a reverse proxy that serves the Next.JS app (best practice!) and uses it to set a cookie that the client code reads on load.