Final Docs Review #515
Merged
Final Docs Review #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jack-berg,
mateuszrzeszutek and
trask
Closed
|
LGTM. With all the file changes let's wait to merge until we get a couple more reviews |
cartersocha
approved these changes
Oct 23, 2022
lalitb
approved these changes
Oct 24, 2022
Merged
|
|
||
| - Recommendation Service (CPU% and Memory) | ||
| - Service Latency (from SpanMetrics) | ||
| - Error Rate |
There was a problem hiding this comment.
- Error Rate (from SpanMetrics) ?
| ### Initializing Tracing | ||
|
|
||
| The OpenTelemetry SDK is initialized from `main` using the `initTracer` | ||
| function defined in `tacer_common.h` |
There was a problem hiding this comment.
tacer_common.h -> tracer_common.h
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add scenario dashboard * docs pass * add scenario * automatically create dashboards * tweak readme intro and update fork info * update header for cartservice * add note on forks * copilot! * document currency service Co-authored-by: Pierre Tessier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be the final docs check for consistency