-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quoteservice] Replace php-cli to php-apache #563
[quoteservice] Replace php-cli to php-apache #563
Conversation
Seems to be running fine. One comment though. Is it possible to fix the two first lines from the log:
|
Good catch @mviitane, fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also the logs were fixed.
@mviitane I've also added OPCache in order to improve the PHP performance (more added to the initial changes text). |
@bobstrecansky would you be able to have a look? |
Seems to be running fine, didn't notice any functional changes. |
No functional change, just better performance. |
* Replace php-cli to php-apache * lint * Changelog * Add ServerName * Add OPCache for better performance Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Changes
PHP-CLI is a PHP built-in server and should not be used in production, more info here: https://www.php.net/manual/en/features.commandline.webserver.php#features.commandline.webserver.
In order to have a service that users can relate to real life services, I've updated the QuoteService to make use of PHP-Apache.
I've also added OPcache in order to improve the PHP performance: https://www.php.net/manual/en/intro.opcache.php
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes