[protobuf] - encode zipcode as a string #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a change log item too? |
reyang
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
The changes look good to me, but when testing I got a weird behavior.
Even though everything was working when the requests were coming from the loadgen, when I tried to navigate to the page and "buy" a product, the shipping was 0,00 and I got the following error in the console:
shipping-service | thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', src/shipping_service.rs:67:91
shipping-service | 07:52:13 [INFO] GetQuoteRequest: Request { metadata: MetadataMap { headers: {"traceparent": "00-70c1bde2eddef2088aaceeefe54d15eb-460f45857d9e8886-01", "grpc-accept-encoding": "identity,deflate,gzip", "accept-encoding": "identity", "user-agent": "grpc-node-js/1.6.7", "content-type": "application/grpc", "te": "trailers"} }, message: GetQuoteRequest { address: None, items: [CartItem { product_id: "66VCHSJNUP", quantity: 1 }] }, extensions: Extensions }
frontend | Error: 1 CANCELLED: Call cancelled
frontend | at Object.callErrorFromStatus (/app/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
frontend | at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client.js:189:52)
frontend | at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:365:141)
frontend | at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
frontend | at /app/node_modules/@grpc/grpc-js/build/src/call-stream.js:187:78
frontend | at processTicksAndRejections (node:internal/process/task_queues:78:11) {
frontend | code: 1,
frontend | details: 'Call cancelled',
frontend | metadata: Metadata { internalRepr: Map(0) {}, options: {} }
frontend | }
I'm not getting any error if I don't navigate via browser.
|
@julianocosta89 can you try again? I made some changes to the frontend code to pass in the dummy address when it attempts to get the shipping quote. |
Fixed! Good one! |
julianocosta89
approved these changes
Nov 21, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* encode zipcode as a string * encode zipcode as a string * encode zipcode as a string * add zip_code attribute * update zipCode to string type * update zipCode to string type * add address to shipping api call * add address to shipping api call * zipcode as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
zipCodeattribute of the Address message to be a string type instead of an int.Also adds an attribute to the shipping service spans that contain the zipCode.