Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featureflag: updates the dependency tls_certificate_check to allow bump to OTP-25 #756

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

tsloughter
Copy link
Member

@tsloughter tsloughter commented Feb 22, 2023

Changes

Please provide a brief description of the changes here.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@tsloughter tsloughter requested a review from a team February 22, 2023 23:04
This was blocked by a failure in featureflag dependency
tls_certificate_check on OTP-25. This was fixed in 1.17.4 and
featureflag service has been bumped to use that version.
@tsloughter
Copy link
Member Author

I haven't been able to test this yet because even on a clean main I can't get the docker compose setup to start up. Will keep trying but opened this in case anyone else can.

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Built it locally and tested the FeatureFlag, all working fine:
image

@cartersocha
Copy link
Contributor

Please add a change log entry

@tsloughter
Copy link
Member Author

@cartersocha done

@cartersocha cartersocha merged commit 32add44 into open-telemetry:main Feb 24, 2023
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants