[collector] update collector to 0.76.1 and remove connectors feature gates #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
julianocosta89
approved these changes
Apr 30, 2023
There was a problem hiding this comment.
Approving this, but it seems that this and the previous update on the collector broke most of the dashboards in Grafana.
We can fix this in a different PR though, the charts are already broken, and this PR keeps the spanmetrics-demo-dashboard updated and working.
puckpuck
added
the
helm-update-required
puckpuck
approved these changes
May 1, 2023
AlexanderWert
pushed a commit
to AlexanderWert/opentelemetry-demo
that referenced
this pull request
Jul 24, 2023
…gates (open-telemetry#857) * update collector to 0.76.1 and remove connectors feature gates Signed-off-by: Ziqi Zhao <[email protected]> * add change log entry Signed-off-by: Ziqi Zhao <[email protected]> --------- Signed-off-by: Ziqi Zhao <[email protected]> Co-authored-by: Carter Socha <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…gates (open-telemetry#857) * update collector to 0.76.1 and remove connectors feature gates Signed-off-by: Ziqi Zhao <[email protected]> * add change log entry Signed-off-by: Ziqi Zhao <[email protected]> --------- Signed-off-by: Ziqi Zhao <[email protected]> Co-authored-by: Carter Socha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
update collector to 0.76.1 and remove connectors feature gates
and in 0.76.1 the metric names produced by spanmetric connector are all changed, so the dashboard should also be updated.
fix #833