Update frontend and integration tests #905
Conversation
| // TODO: this validation is always returning 2 instead of 0, probably because of | ||
| // the cache leakage scenario, it makes sense to create two validations | ||
| // one for the leakage and another to the "normal" condition? | ||
| //t.is(arrayIntersection(res.productIds, req.productIds).length, 0); |
There was a problem hiding this comment.
Folks, I commented on this assertion because I'm not sure what we can do with this assertion. Do you have any suggestions?
There was a problem hiding this comment.
The cache leak scenario should never be exercised when tests are running so I'd make it work for the happy path and not the sad one
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
danielbdias
force-pushed
the
fix/frontend-and-integration-tests
branch
from
323424e
to
26da8e7
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Any update on comments here? |
|
hi @austinlparker ! I was on vacation last week, I'm planning to tackle the issue with the ProductCatalog test in the next few days. I should have this PR ready to review again on Monday. |
|
Hi folks! Giving a heads up here, I'm still trying to fix the test mentioned in this comment. |
|
Hi folks! I'm still checking what happened with the failing integration test, and I'll need more time to tackle it. Thinking about that, I'll close this PR to investigate it and reopen it later as soon as I have a solution for that. (I'll ping on CNCF Slack to get the context better for the error). As the frontend tests are solved, I opened another PR just for them: #950 |
Changes
Today the integration and frontend tests are broken because they validate only 9 products sent by the ProductCatalog, causing our tests to fail when running
make run-tests.Also, the email test returns a false positive because we have a validation
t.truthy(true)on this test. I updated the test data and changed this validation tot.truthy(res.ok)to guarantee that this endpoint is returning anHTTP 200answer.This PR fixes the assertions to consider the product added on #656 too.
To run these tests locally, first, you need to build both images with the following command:
And later just run:
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.