chore: add OTEL_COLLECTOR_PORT env for frontendproxy to support 1.4 image #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chigia001
force-pushed
the
fix-docker-compose-compatiple-1.4
branch
2 times, most recently
from
ee7203d
to
8a45d39
Compare
chigia001
force-pushed
the
fix-docker-compose-compatiple-1.4
branch
from
8a45d39
to
71386cd
Compare
|
I'm not sure how to handle these two piece: If the developer run with 1.4.0-frontendproxy publised image, this endpoint will not work. So the cluster will start successfully but unable to collect any span for front end :( Should we also revert these change and only update to |
|
Close this in favor of a new published image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since #938 we has rename OTEL_COLLECTOR_PORT to OTEL_COLLECTOR_PORT_GRPC, this make our docker-compose.yml incompatiple with https://ghcr.io/open-telemetry/demo:1.4-frontendproxy publish image. This cause new user that try to setup with
docker compose up --no-buildfail to start.This PR introduce back OTEL_COLLECTOR_PORT but only in
This should fixes #971
We should remove these env after 1.5 is release
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions