-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Runtime] Add a metric for total paused duration in GC for .NET 7 and greater versions #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
- Coverage 73.61% 72.99% -0.62%
==========================================
Files 265 265
Lines 9346 9287 -59
==========================================
- Hits 6880 6779 -101
- Misses 2466 2508 +42
|
Kielek
reviewed
Jun 15, 2023
twenzel
reviewed
Jun 15, 2023
xiang17
changed the title
[Instrumentation.Runtime] Add a metric for total paused duration in GC
[Instrumentation.Runtime] Add a metric for total paused duration in GC for .NET 7 and greater versions
Jun 15, 2023
Kielek
approved these changes
Jun 15, 2023
twenzel
approved these changes
Jun 15, 2023
cijothomas
reviewed
Jun 15, 2023
cijothomas
approved these changes
Jun 15, 2023
twenzel
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1163.
Changes
Add a new metric for total paused duration in GC
process.runtime.dotnet.gc.duration
with data from GC.GetTotalPauseDuration Method.It is recommended over the
time-in-gc
EventCounter in the Well-known EventCounters in .NET.The metrics would show in the output of Prometheus Exporter HttpListener (for how to set it up, follow this getting-started guide) like this:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes