Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Container] Add Kubernetes support #1699

Open
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

joegoldman2
Copy link
Contributor

Fixes #1562.
Only tested manually at the moment.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 49.43820% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (71655ce) to head (7925207).
Report is 600 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry.Resources.Container/K8sMetadataFetcher.cs 0.00% 20 Missing ⚠️
...Telemetry.Resources.Container/ContainerDetector.cs 72.54% 14 Missing ⚠️
...esources.Container/ContainerResourceEventSource.cs 21.42% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   73.91%   71.25%   -2.66%     
==========================================
  Files         267      368     +101     
  Lines        9615    14105    +4490     
==========================================
+ Hits         7107    10051    +2944     
- Misses       2508     4054    +1546     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 77.13% <ø> (?)
unittests-Exporter.Geneva 58.70% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.58% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 86.27% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 70.33% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.37% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 74.11% <ø> (?)
unittests-Instrumentation.Owin 88.12% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 98.02% <ø> (?)
unittests-Instrumentation.SqlClient 89.77% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.26% <ø> (?)
unittests-Instrumentation.Wcf 49.37% <ø> (?)
unittests-PersistentStorage 65.88% <ø> (?)
unittests-Resources.AWS 75.90% <ø> (?)
unittests-Resources.Azure 85.03% <ø> (?)
unittests-Resources.Container 55.17% <49.43%> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 75.40% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...y.Resources.Container/Models/K8sContainerStatus.cs 100.00% <100.00%> (ø)
...OpenTelemetry.Resources.Container/Models/K8sPod.cs 100.00% <100.00%> (ø)
...lemetry.Resources.Container/Models/K8sPodStatus.cs 100.00% <100.00%> (ø)
...esources.Container/ContainerResourceEventSource.cs 21.42% <21.42%> (ø)
...Telemetry.Resources.Container/ContainerDetector.cs 74.66% <72.54%> (ø)
...elemetry.Resources.Container/K8sMetadataFetcher.cs 0.00% <0.00%> (ø)

... and 373 files with indirect coverage changes

@joegoldman2 joegoldman2 changed the title Add Kubernetes support in Container Resource Detector [ResourceDetectors.Container] Add Kubernetes support Apr 27, 2024
@Kielek Kielek added the comp:resources.container Things related to OpenTelemetry.Resources.Container label May 6, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 15, 2024
@iskiselev
Copy link
Contributor

Not stale. I'll try to finish review this week.

@github-actions github-actions bot added the Stale label Oct 3, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 15, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 25, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.container Things related to OpenTelemetry.Resources.Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect container id reported
10 participants