Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Process related metrics from .NET Runtime metrics #446

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jun 21, 2022

For #335.

Changes

Remove Process related metrics from .NET Runtime metrics.

These metrics should be added in a separate package and with OpenTelemetry.Instrumentation.Process as a potential name.

For significant contributions please make sure you have completed the following items:

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #446 (08047ae) into main (ff1033a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #446   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        163     163           
  Lines       4909    4898   -11     
=====================================
+ Misses      4909    4898   -11     
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <ø> (ø)
...y.Instrumentation.Runtime/RuntimeMetricsOptions.cs 0.00% <ø> (ø)

@xiang17 xiang17 marked this pull request as ready for review June 21, 2022 23:42
@xiang17 xiang17 requested a review from a team June 21, 2022 23:42
@utpilla utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Jun 22, 2022
@cijothomas cijothomas merged commit 8da864c into open-telemetry:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants