Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Runtime] Enable CodeAnalysis for Runtime Instrumentation library #555

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Aug 1, 2022

Enable CodeAnalysis for Runtime Instrumentation library.

Changes

Set EnableAnalysis to true in OpenTelemetry.Instrumentation.Runtime.csproj.

For significant contributions please make sure you have completed the following items:

@xiang17 xiang17 requested a review from a team August 1, 2022 22:39
@utpilla utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #555 (0d0200e) into main (355643c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #555   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        167     167           
  Lines       5102    5101    -1     
=====================================
+ Misses      5102    5101    -1     
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <ø> (ø)

@cijothomas cijothomas merged commit 0a584e6 into open-telemetry:main Aug 2, 2022
@xiang17 xiang17 deleted the xiang17/CodeAnalysis branch August 2, 2022 01:17
samimusallam pushed a commit to samimusallam/opentelemetry-dotnet-contrib that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants