-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing db providers to db.system #898
Add missing db providers to db.system #898
Conversation
1f6d165
to
c8cdaa4
Compare
Please. consider to create PR similar to open-telemetry/opentelemetry-specification#2718. Bassed on other values, I suppose just |
Opened, omitted efcore in memory and filecontext core cause they're more for prototyping purposes to some degree imho. open-telemetry/opentelemetry-specification#3105 |
...etry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
72a325f
to
9bd909e
Compare
@Kielek Pr is now merged to the specs so the naming is matching. I've decided to omit the ibm ones as it's not possible to differentiate between db2 or informix. If we want to include, it needs to be a more generic banner. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 69.83% 69.23% -0.61%
==========================================
Files 202 200 -2
Lines 7682 7648 -34
==========================================
- Hits 5365 5295 -70
- Misses 2317 2353 +36
|
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Fixes #882, outstanding question is the ibm provider as it can represent two different dbs. I'm inclined to favour putting it under other rather than a generic banner.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesdb.system
tags. #882