Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing db providers to db.system #898

Merged
merged 18 commits into from
Mar 2, 2023

Conversation

mrblonde91
Copy link
Contributor

@mrblonde91 mrblonde91 commented Jan 15, 2023

Fixes #882, outstanding question is the ibm provider as it can represent two different dbs. I'm inclined to favour putting it under other rather than a generic banner.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

@mrblonde91 mrblonde91 requested a review from a team January 15, 2023 18:21
@mrblonde91 mrblonde91 changed the title Feature/updatesystems Add missing db providers to db.system Jan 15, 2023
@Kielek
Copy link
Contributor

Kielek commented Jan 16, 2023

Labeled spanner as gcp_spanner as it's not currently got a naming scheme.

Please. consider to create PR similar to open-telemetry/opentelemetry-specification#2718. Bassed on other values, I suppose just spanner will be better value.

@mrblonde91
Copy link
Contributor Author

Labeled spanner as gcp_spanner as it's not currently got a naming scheme.

Please. consider to create PR similar to open-telemetry/opentelemetry-specification#2718. Bassed on other values, I suppose just spanner will be better value.

Opened, omitted efcore in memory and filecontext core cause they're more for prototyping purposes to some degree imho. open-telemetry/opentelemetry-specification#3105

@Kielek Kielek added the comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore label Jan 19, 2023
@mrblonde91
Copy link
Contributor Author

@Kielek Pr is now merged to the specs so the naming is matching. I've decided to omit the ibm ones as it's not possible to differentiate between db2 or informix. If we want to include, it needs to be a more generic banner.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #898 (83f0a5c) into main (16d8891) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

❗ Current head 83f0a5c differs from pull request most recent head 3ef2e2a. Consider uploading reports for the commit 3ef2e2a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   69.83%   69.23%   -0.61%     
==========================================
  Files         202      200       -2     
  Lines        7682     7648      -34     
==========================================
- Hits         5365     5295      -70     
- Misses       2317     2353      +36     
Impacted Files Coverage Δ
...mplementation/EntityFrameworkDiagnosticListener.cs 50.89% <0.00%> (-8.49%) ⬇️
...r.Geneva/Metrics/GenevaMetricExporterExtensions.cs 0.00% <0.00%> (-90.00%) ⬇️
...Geneva/Metrics/Transport/MetricEtwDataTransport.cs 25.00% <0.00%> (-50.00%) ⬇️
...neCollector/Logs/OneCollectorLogExporterBuilder.cs 31.81% <0.00%> (-13.64%) ⬇️
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 58.49% <0.00%> (-8.94%) ⬇️
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 95.00% <0.00%> (-5.00%) ⬇️
...metry.Exporter.Instana/Implementation/Transport.cs 0.00% <0.00%> (ø)
...xporter.Instana/TracerProviderBuilderExtensions.cs 0.00% <0.00%> (ø)
...porter.OneCollector/OneCollectorExporterOptions.cs 100.00% <0.00%> (ø)
...eCollector/OneCollectorExporterTransportOptions.cs 72.22% <0.00%> (ø)
... and 8 more

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 11, 2023
@github-actions github-actions bot removed the Stale label Feb 12, 2023
@utpilla utpilla merged commit fd72cac into open-telemetry:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instrumentation.EntityFrameworkCore] Extend db.system tags.
5 participants