Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status & error flag updates to match spec #1655

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Dec 11, 2020

Changes

Updated Status & Zipkin/Jaeger exporter error flag handling based on final merged PR into spec.

TODOs:

  • CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team December 11, 2020 07:45
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1655 (15f2bfc) into master (7a3f5e7) will increase coverage by 0.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
+ Coverage   81.79%   81.80%   +0.01%     
==========================================
  Files         245      245              
  Lines        6590     6605      +15     
==========================================
+ Hits         5390     5403      +13     
- Misses       1200     1202       +2     
Impacted Files Coverage Δ
....Jaeger/Implementation/JaegerActivityExtensions.cs 94.96% <66.66%> (-0.66%) ⬇️
src/OpenTelemetry.Api/Trace/Status.cs 100.00% <100.00%> (+3.70%) ⬆️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 85.26% <100.00%> (+0.31%) ⬆️
...plementation/ZipkinActivityConversionExtensions.cs 98.92% <100.00%> (+0.14%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️

@cijothomas cijothomas merged commit 8cda9ef into open-telemetry:master Dec 14, 2020
@CodeBlanch CodeBlanch deleted the error-flag-spec-updates branch December 15, 2020 02:39
alanwest added a commit to newrelic/newrelic-telemetry-sdk-dotnet that referenced this pull request Feb 2, 2021
* Update to OpenTelemetry 1.0.0-rc2

* Update changelog

* Setting description on span with Ok status ignores the description. See open-telemetry/opentelemetry-dotnet#1655.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants