Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid code coverage run on push trigger" #1891

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

cijothomas
Copy link
Member

Reverts #1849

To see if this will fix code coverage base commmit

@cijothomas cijothomas requested a review from a team March 10, 2021 00:08
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1891 (cac19e8) into main (cb066cb) will decrease coverage by 0.49%.
The diff coverage is 79.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
- Coverage   83.77%   83.28%   -0.50%     
==========================================
  Files         187      188       +1     
  Lines        5967     6139     +172     
==========================================
+ Hits         4999     5113     +114     
- Misses        968     1026      +58     
Impacted Files Coverage Δ
src/OpenTelemetry/Sdk.cs 100.00% <ø> (ø)
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 26.82% <20.54%> (-44.60%) ⬇️
src/OpenTelemetry/Logs/LogRecord.cs 82.50% <77.77%> (-5.00%) ⬇️
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs 77.55% <88.23%> (+7.09%) ⬆️
src/OpenTelemetry/Trace/ExceptionProcessor.cs 90.90% <90.90%> (ø)
...rc/OpenTelemetry/Trace/TracerProviderBuilderSdk.cs 89.83% <91.66%> (-0.92%) ⬇️
src/OpenTelemetry/Trace/TracerProviderSdk.cs 95.37% <98.79%> (+4.59%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 86.89% <100.00%> (+0.05%) ⬆️
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs 100.00% <100.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 89.10% <100.00%> (ø)
... and 24 more

@cijothomas cijothomas merged commit c51d2cf into main Mar 10, 2021
@cijothomas cijothomas deleted the revert-1849-reyang/ci branch March 10, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants