Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suppress inc and dec from diagnosticsourcelisteners #1893

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Mar 10, 2021

as TracerProviderSdk is the sole place controlling start and stop of activities and feeding to processor pipeline.
(This is cause TracerProviderSdk now natively listens to legacy activities start/stop after #1836)

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

…viderSdk is the sole place controlling with start and stop of activities and feeding to processor pipeline
@cijothomas cijothomas marked this pull request as ready for review March 10, 2021 02:43
@cijothomas cijothomas requested a review from a team March 10, 2021 02:43
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1893 (6d5e09c) into main (c51d2cf) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
- Coverage   83.36%   83.33%   -0.04%     
==========================================
  Files         188      188              
  Lines        6139     6137       -2     
==========================================
- Hits         5118     5114       -4     
- Misses       1021     1023       +2     
Impacted Files Coverage Δ
...cSourceInstrumentation/DiagnosticSourceListener.cs 78.26% <100.00%> (-1.74%) ⬇️
src/OpenTelemetry/SuppressInstrumentationScope.cs 95.65% <0.00%> (-4.35%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants