-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Sync up logger provider build-up scenarios with tracer provider #3596
[Logs] Sync up logger provider build-up scenarios with tracer provider #3596
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3596 +/- ##
==========================================
+ Coverage 87.14% 87.34% +0.20%
==========================================
Files 280 282 +2
Lines 10112 10132 +20
==========================================
+ Hits 8812 8850 +38
+ Misses 1300 1282 -18
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
/// </remarks> | ||
public class BatchExportLogRecordProcessorOptions : BatchExportProcessorOptions<LogRecord> | ||
{ | ||
internal const string MaxQueueSizeEnvVarKey = "OTEL_DOTNET_BLP_MAX_QUEUE_SIZE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the spec will declare official environment variable names. You think we can be optimistic and remove DOTNET
from these environment variable names and just go with OTEL_BLP_MAX_QUEUE_SIZE
for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh scratch that i just saw the previous resolved conversation..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to keep moving. Hoping to settle the environment variables before stable release. |
Changes
This PR syncs up the LoggerProvider scenarios (added on #3504) with the TracerProvider scenarios (#3533)
BaseProcessor<LogRecord>
s &Action<IServiceProvider, OpenTelemetryLoggerProvider>
s into theIServiceCollection
Public API
TODOs
CHANGELOG.md
updated for non-trivial changes