-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update Jaeger tutorial to use OTLP Exporter #3940
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid 👍
Hi @reyang and @Kielek , thanks for your review and approve this PR. Since there're some errors in CI about failed CI action: https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/3538390359 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3940 +/- ##
==========================================
+ Coverage 85.18% 85.25% +0.06%
==========================================
Files 287 287
Lines 11026 11026
==========================================
+ Hits 9393 9400 +7
+ Misses 1633 1626 -7
|
rebased all main commits. I've tested locally and think/hope there's no CI error.. |
docs/trace/getting-started-jaeger/getting-started-jaeger.csproj
Outdated
Show resolved
Hide resolved
docs/trace/getting-started-jaeger/getting-started-jaeger.csproj
Outdated
Show resolved
Hide resolved
docs/trace/getting-started-jaeger/getting-started-jaeger.csproj
Outdated
Show resolved
Hide resolved
@open-telemetry/dotnet-maintainers this looks good to merge. |
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Instrumentation.Http\OpenTelemetry.Instrumentation.Http.csproj" /> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<PackageReference Include="System.Net.Http" Version="4.3.4" Condition="$(TargetFramework) == 'net472' or $(TargetFramework) == 'net48'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest @utpilla This change piqued my interest. We don't specify targets explicitly. When I build this project locally I get output for net7.0, net6.0, net462, net47, net471, net472, & net48. It is interesting that net462, net47, & net471 don't also need this reference 🤔 But it raises a question: Should we specify targets on these docs projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard! I found the targets defined here: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/Directory.Build.props#L8-L10
For #3925 , Update Jaeger tutorial to use OTLP Exporter.
Changes
Please provide a brief description of the changes here.
Program.cs
for Jaeger tutorial.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes