-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpWebRequest] Add error.type
for trace and metric
#5034
Merged
utpilla
merged 9 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-error-type-httpwebrequest
Nov 9, 2023
Merged
[HttpWebRequest] Add error.type
for trace and metric
#5034
utpilla
merged 9 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-error-type-httpwebrequest
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishweshbankwar
changed the title
[HttpWebRequest] Add
[HttpWebRequest] Add Nov 9, 2023
error.type
error.type
for trace and metric
Codecov Report
@@ Coverage Diff @@
## main #5034 +/- ##
==========================================
+ Coverage 83.38% 83.60% +0.22%
==========================================
Files 296 296
Lines 12440 12467 +27
==========================================
+ Hits 10373 10423 +50
+ Misses 2067 2044 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodeBlanch
reviewed
Nov 9, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
utpilla
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Sets
error.type
for trace andhttp.client.request.duration
metric for HttpWebRequest. Spec: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#common-attributesTODO: Document possible
error.type
values as suggested by spec.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes