Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpWebRequest] Add error.type for trace and metric #5034

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 9, 2023

Fixes #
Design discussion issue #

Changes

Sets error.type for trace and http.client.request.duration metric for HttpWebRequest. Spec: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#common-attributes

TODO: Document possible error.type values as suggested by spec.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar changed the title [HttpWebRequest] Add error.type [HttpWebRequest] Add error.type for trace and metric Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5034 (bea7bd5) into main (00750dd) will increase coverage by 0.22%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5034      +/-   ##
==========================================
+ Coverage   83.38%   83.60%   +0.22%     
==========================================
  Files         296      296              
  Lines       12440    12467      +27     
==========================================
+ Hits        10373    10423      +50     
+ Misses       2067     2044      -23     
Flag Coverage Δ
unittests 83.60% <74.19%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rumentation.Http/Implementation/TelemetryHelper.cs 83.33% <75.00%> (-4.17%) ⬇️
...plementation/HttpWebRequestActivitySource.netfx.cs 82.71% <73.91%> (-0.42%) ⬇️

... and 7 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 9, 2023 18:07
@vishweshbankwar vishweshbankwar requested a review from a team November 9, 2023 18:07
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit 94ede6e into open-telemetry:main Nov 9, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants