Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rc dependencies to net8.0 stable #5051

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 14, 2023 22:53
@vishweshbankwar vishweshbankwar requested a review from a team November 14, 2023 22:53
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #5051 (b116965) into main (201811a) will decrease coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5051      +/-   ##
==========================================
- Coverage   83.54%   83.35%   -0.20%     
==========================================
  Files         296      296              
  Lines       12473    12473              
==========================================
- Hits        10421    10397      -24     
- Misses       2052     2076      +24     
Flag Coverage Δ
unittests 83.35% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@utpilla utpilla merged commit b0f9607 into open-telemetry:main Nov 14, 2023
68 checks passed
@srogovtsev
Copy link

srogovtsev commented Nov 29, 2023

Is this change really required? We would like to use OpenTelemetry from a legacy ASP.NET forms application, and due to some legacy issues we cannot bring in Microsoft.Extensions.Options (or any other .NET Extensions package) newer than 3.1. Previous minor version packages used 3.1:

  • OpenTelemetry 1.6 uses Microsoft.Extensions.Logging.Configuration (>= 3.1.0)
  • OpenTelemetry.Api.ProviderBuilderExtensions 1.6 uses Microsoft.Extensions.DependencyInjection.Abstractions (>= 3.1.0)

@CodeBlanch
Copy link
Member

@srogovtsev What's the issue that prevents you from bumping the M.E.* packages? Is it this thing with InplaceStringBuilder being removed from Microsoft.Extensions.Primitives? If that is the case FYI it seems to have been fixed in v8: dotnet/runtime#85846

@srogovtsev
Copy link

@CodeBlanch , it's exactly that! Thank you for the information, we'll see if we can use this to our advantage!

@srogovtsev
Copy link

I just wanted to follow up by saying that preliminary results show everything working for us with M.E 8, which is so an unexpected relief. We've been trying to upgrade for some years.

@CodeBlanch , thanks again oh-so-much for this hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants