Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extension classes for HttpClient and Asp.Net Core #5161

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Renames classes for better support doc generation (docfx).

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review December 12, 2023 22:11
@vishweshbankwar vishweshbankwar requested a review from a team December 12, 2023 22:11
@vishweshbankwar vishweshbankwar changed the title Rename extension classes for HttpClient and Asp.NetCore Rename extension classes for HttpClient and Asp.Net Core Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #5161 (ca5b3ac) into main (486ee58) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5161      +/-   ##
==========================================
- Coverage   83.45%   83.43%   -0.03%     
==========================================
  Files         297      297              
  Lines       12368    12368              
==========================================
- Hits        10322    10319       -3     
- Misses       2046     2049       +3     
Flag Coverage Δ
unittests 83.43% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...reInstrumentationMeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...eInstrumentationTracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...ntInstrumentationMeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...tInstrumentationTracerProviderBuilderExtensions.cs 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit 7fec53d into open-telemetry:main Dec 12, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants