-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.OpenTelemetryProtocol] fix event source throws System.FormatException
#5451
[Exporter.OpenTelemetryProtocol] fix event source throws System.FormatException
#5451
Conversation
System.FormatException
@@ -14,4 +16,16 @@ public void EventSourceTest_OpenTelemetryProtocolExporterEventSource() | |||
{ | |||
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(OpenTelemetryProtocolExporterEventSource.Log); | |||
} | |||
|
|||
[Fact] | |||
public void EventSourceTest_PersistentStorageAbstractionsEventSource() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
==========================================
+ Coverage 83.38% 85.37% +1.98%
==========================================
Files 297 289 -8
Lines 12531 12422 -109
==========================================
+ Hits 10449 10605 +156
+ Misses 2082 1817 -265
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good reason why to move to ILogger #3881.
This PR fixes a bug in the PersistentStorageEventSource class.
Changes