Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Context nullable annotations #5850

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CodeBlanch
Copy link
Member

Relates to #5801

Changes

  • Adds nullable annotations for the Context API

Details

This was split off from #5801 so it could be reviewed/discussed independently.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team as a code owner September 19, 2024 21:20
@github-actions github-actions bot added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (6250307) to head (754f100).
Report is 318 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry.Api/Context/RemotingRuntimeContextSlot.cs 0.00% 9 Missing ⚠️
...metry.Api/Context/ThreadLocalRuntimeContextSlot.cs 0.00% 4 Missing ⚠️
src/OpenTelemetry.Api/Context/RuntimeContext.cs 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
+ Coverage   83.38%   86.27%   +2.88%     
==========================================
  Files         297      257      -40     
  Lines       12531    11176    -1355     
==========================================
- Hits        10449     9642     -807     
+ Misses       2082     1534     -548     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.19% <30.43%> (?)
unittests-Project-Stable 86.14% <30.43%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...emetry.Api/Context/AsyncLocalRuntimeContextSlot.cs 100.00% <100.00%> (+25.00%) ⬆️
...rc/OpenTelemetry.Api/Context/RuntimeContextSlot.cs 55.55% <100.00%> (+5.55%) ⬆️
src/OpenTelemetry.Api/Context/RuntimeContext.cs 47.72% <40.00%> (-0.10%) ⬇️
...metry.Api/Context/ThreadLocalRuntimeContextSlot.cs 0.00% <0.00%> (ø)
...elemetry.Api/Context/RemotingRuntimeContextSlot.cs 0.00% <0.00%> (ø)

... and 225 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant