otelgrpc: Stablize TestInterceptors (#4535)

open-telemetry · Nov 8, 2023 · f6aeb0d · f6aeb0d
1 parent b44dfc9
commit f6aeb0d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go b/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go
@@ -19,6 +19,7 @@ import (
 	"net"
 	"strconv"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -136,6 +137,12 @@ func TestInterceptors(t *testing.T) {
 	})
 
 	t.Run("StreamClientSpans", func(t *testing.T) {
+		// StreamClientInterceptor ends the spans asynchronously.
+		// We need to wait for all spans before asserting them.
+		require.EventuallyWithT(t, func(c *assert.CollectT) {
+			assert.Len(c, clientStreamSR.Ended(), 3)
+		}, 5*time.Second, 100*time.Millisecond)
+
 		checkStreamClientSpans(t, clientStreamSR.Ended(), listener.Addr().String())
 	})