-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC metrics record duration in nanoseconds instead of milliseconds #4547
Comments
I will file a pull request for this momentarily. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Shouldn't all duration metrics be in seconds? I think I saw this requirement/recommendation somewhere in the spec. For histograms this would mean using custom buckets (which is now possible!) as the default ones would not be granular enough for "seconds" resolution. |
@ash2k please open an issue to track this independently. For what it's worth, the change from |
Description
RPC metrics are recording float64 of nanoseconds instead of milliseconds as they are intended to.
Expected behavior
If a float is going to be used to record RPC durations (similar to what is done for HTTP durations) we should be recording milliseconds and not nanoseconds.
The text was updated successfully, but these errors were encountered: