Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create runtime.Config struct with metric.Provider and WithMinimumReadMemStatsInterval() configuration options #224

Merged
merged 9 commits into from
Aug 18, 2020
Merged

Create runtime.Config struct with metric.Provider and WithMinimumReadMemStatsInterval() configuration options #224

merged 9 commits into from
Aug 18, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Aug 14, 2020

Part of #213.

evantorrie
evantorrie reviewed Aug 14, 2020
View reviewed changes
instrumentation/runtime/runtime.go Outdated Show resolved Hide resolved
instrumentation/runtime/runtime.go Outdated Show resolved Hide resolved
instrumentation/runtime/runtime.go Outdated Show resolved Hide resolved
MrAlias
MrAlias reviewed Aug 15, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the instrumentation addition 👍, but could use some cleanup.

instrumentation/runtime/go.mod Outdated Show resolved Hide resolved
instrumentation/runtime/runtime.go Outdated Show resolved Hide resolved
instrumentation/runtime/doc.go Outdated Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Aug 15, 2020
Closed
@jmacd jmacd changed the title Pass a metric.Provider to runtime.Start(); makeWithMinimumGCStatsInterval() a configuration an option. Pass a metric.Provider to runtime.Start(); makeWithMinimumGCStatsInterval() configuration an option. Aug 15, 2020
@jmacd jmacd changed the title Pass a metric.Provider to runtime.Start(); makeWithMinimumGCStatsInterval() configuration an option. Pass a metric.Provider to runtime.Start(); make WithMinimumReadMemStatsInterval() configuration an option. Aug 16, 2020
@jmacd jmacd changed the title Pass a metric.Provider to runtime.Start(); make WithMinimumReadMemStatsInterval() configuration an option. Create runtime.Config struct with metric.Provider and WithMinimumReadMemStatsInterval() configuration options Aug 16, 2020
@jmacd
Copy link
Contributor Author

jmacd commented Aug 16, 2020

From a terminology perspective, there's one lingering concern. We've written WithMeterProvider() for a class named metric.Provider over and over again. I wonder if we should rename metric.Provider to metric.MeterProvider, but such a rename might cause more trouble than it's worth.

@MrAlias
Copy link
Contributor

MrAlias commented Aug 17, 2020

From a terminology perspective, there's one lingering concern. We've written WithMeterProvider() for a class named metric.Provider over and over again. I wonder if we should rename metric.Provider to metric.MeterProvider, but such a rename might cause more trouble than it's worth.

I've been passively thinking of needing this kind of rename if we wanted to move the provider to the top level (alongside a TraceProvider). Sounds reasonable to me.

@jmacd
Copy link
Contributor Author

jmacd commented Aug 17, 2020

I've been passively thinking of needing this kind of rename if we wanted to move the provider to the top level (alongside a TraceProvider).

I like this idea!

MrAlias
MrAlias approved these changes Aug 18, 2020
View reviewed changes
instrumentation/runtime/runtime.go Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Aug 18, 2020
Closed
@MrAlias MrAlias merged commit a60647b into open-telemetry:master Aug 18, 2020
@Aneurysm9 Aneurysm9 mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@evantorrie evantorrie evantorrie approved these changes

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmacd @MrAlias @Aneurysm9 @evantorrie